mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53500: Used an environment variable to pass command environment.
Date Wed, 09 Nov 2016 10:37:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53500/#review155417
-----------------------------------------------------------



The Docker containerizer still passes the env variables to the executor through cmd line flags,
we might want to fix that as well:

https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L244
https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L351-L372


src/slave/containerizer/mesos/containerizer.cpp (line 1400)
<https://reviews.apache.org/r/53500/#comment225351>

    There's a typo here, it should be `launch` instead of `lauch.`


- Gastón Kleiman


On Nov. 8, 2016, 4:46 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53500/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 4:46 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6526
>     https://issues.apache.org/jira/browse/MESOS-6526
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used an environment variable to pass command environment.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 32fba7697b7488b63192c4e9630ff348c572e424

>   src/slave/containerizer/mesos/main.cpp 1a0e765ddb6d8519426b8d47067efdfa3432e07a 
> 
> Diff: https://reviews.apache.org/r/53500/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> No new tests are written but the fact the existing tests that run exectuors depends on
this to work correctly is a proof.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message