mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53567: Improved CREATE operation validation error message.
Date Wed, 09 Nov 2016 04:57:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53567/#review155406
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53567]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 8, 2016, 4:56 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53567/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added more context about the volume in the error message and removed
> unnecessary words.
> 
> Note that the callers to this function prepends framework ID in logging this error.
> 
> More context for this change at /r/52587/
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 658f0dd1085c83cd82f8d2b0e2c4ec0ba785bb92 
> 
> Diff: https://reviews.apache.org/r/53567/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message