mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52645: Harden Mesos
Date Tue, 08 Nov 2016 22:18:54 GMT


> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 120
> > <https://reviews.apache.org/r/52645/diff/7/?file=1550864#file1550864line120>
> >
> >     Not sure we want to remove the existing `-Werror`.
> 
> Aaron Wood wrote:
>     From a discussion with a few people on Slack it sounded like this was in the wrong
place to begin with (along with `-Wall` and `-Wsign-compare`). I found that when I had moved
this to `AM_CXXFLAGS` it would actually apply hard errors for warnings where it never did
before. The issue now with putting this back into `AM_CXXFLAGS` is that all of the `clang:
error: argument unused during compilation: '-pthread'` warnings you get when building Mesos
which were always there now fail the whole thing. I think we'd have to unravel the overall
build process more to fix that issue.
> 
> Aaron Wood wrote:
>     Dropping this for now. If you feel it's really important we can open it again :)

I feel it is really important. With this we'd suddenly not fail a build introducing new warnings
anymore. This might lead to people (or some CI) to conclude such a build would be fine.

Let's just leave it in `MESOS_CPPFLAGS`.


> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote:
> > m4/ax_check_compile_flag.m4, line 1
> > <https://reviews.apache.org/r/52645/diff/7/?file=1550863#file1550863line1>
> >
> >     For future updates it would be great if we'd write down the autoconf-archive
release this file came from (it looks like the latest release containing it is `v2016.09.16`).

You marked this as resolved, but I couldn't find the change. Could you please update e.g.,
the commit message to include something like

    This commit adds ax_check_compiler_flag.m4 from git://git.sv.gnu.org/autoconf-archive.git
tag v2016.09.16.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/#review154524
-----------------------------------------------------------


On Nov. 8, 2016, 6:40 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52645/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 6:40 p.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6229
>     https://issues.apache.org/jira/browse/MESOS-6229
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use a default set of flags to provide additional security and hardening to Mesos. Additionally,
check and catch more warnings/errors.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5380cbc 
>   m4/ax_check_compile_flag.m4 PRE-CREATION 
>   src/Makefile.am 5a47c93 
> 
> Diff: https://reviews.apache.org/r/52645/diff/
> 
> 
> Testing
> -------
> 
> Compared the benchmarks with and without the flags being used. Also did a comparsion
with the flags being used with and without optimizations and without the flags being used
with and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message