mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 53585: Added a default PATH environment variable when launching a container.
Date Tue, 08 Nov 2016 21:49:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53585/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-6543
    https://issues.apache.org/jira/browse/MESOS-6543


Repository: mesos


Description
-------

Having an environment set but no PATH variable set inside of it,
will trigger an `execvpe` call in launch.cpp on the command we are
trying to launch. Normally this doesn't casue problems because
`execvpe` with call `confstr(_CS_PATH)` under the hood to set up a
default path to use when lookiing up our command.

However, when provisioning a new filesystem for a container, its
possible that the `confstr(_CS_PATH)` called from the agent may not
return the same path as a `confstr(_CS_PATH)` call would return using
the libc installed inside the container. This can lead to problems
(for example) with finding the `sh` command in containers based on an
alpine linux image.

We observed this in our test setup with `confstr(_CS_PATH)` on the
agent returning `/usr/bin`, while alpine linux only has the `sh`
command installed in `/bin`.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp 377a9d94aa780ab598b1c2034c10ce25a4e02cbe 

Diff: https://reviews.apache.org/r/53585/diff/


Testing
-------

make -j check


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message