mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53571: Improved some operation validation tests.
Date Tue, 08 Nov 2016 20:43:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53571/#review155351
-----------------------------------------------------------



Patch looks great!

Reviews applied: [52642, 53470, 53529, 53528, 53534, 53571]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 8, 2016, 10:23 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53571/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 10:23 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Removed some tests that don't make sense.
> * Renamed some tests to be consistent with what they check.
> * Improved/fixed some test descriptions.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 8697bb2dc05c54553066ace58553f0e40dfcb5f5 
> 
> Diff: https://reviews.apache.org/r/53571/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="" make -j 4 check V=0`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message