mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 52642: Improved the validation of RESERVE operations.
Date Tue, 08 Nov 2016 10:37:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52642/#review155276
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the formatting issues and will commit it shortly. Please follow-up with the fixes
we've discovered during the review.


src/master/validation.cpp (lines 1426 - 1427)
<https://reviews.apache.org/r/52642/#comment225147>

    We usually make trailing space leading one (it's easier to see when a space is missing).



src/master/validation.cpp (lines 1460 - 1462)
<https://reviews.apache.org/r/52642/#comment225148>

    Ditto.



src/tests/master_validation_tests.cpp (lines 311 - 313)
<https://reviews.apache.org/r/52642/#comment225152>

    This test does not do what it says. It's a copy-paste of `ReserveOperationValidationTest.MatchingPrincipal)`.
Could you please fix it.



src/tests/master_validation_tests.cpp (lines 387 - 403)
<https://reviews.apache.org/r/52642/#comment225153>

    Again, the former test does not do what it says and should be killed in favour of the
latter one.


- Alexander Rukletsov


On Nov. 7, 2016, 11:02 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52642/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-6142
>     https://issues.apache.org/jira/browse/MESOS-6142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Don't allow a reservation if the framework role doesn't match the role
> of all the resources.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 
>   src/master/validation.hpp ed878ef64c6bc49cfa1738f97c7af047f06ffee7 
>   src/master/validation.cpp 658f0dd1085c83cd82f8d2b0e2c4ec0ba785bb92 
>   src/tests/master_validation_tests.cpp 8697bb2dc05c54553066ace58553f0e40dfcb5f5 
> 
> Diff: https://reviews.apache.org/r/52642/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message