mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <armand.gril...@gmail.com>
Subject Review Request 53559: Transformed env variable parsing into Flags in process.cpp.
Date Tue, 08 Nov 2016 01:51:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53559/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Bugs: MESOS-4609
    https://issues.apache.org/jira/browse/MESOS-4609


Repository: mesos


Description
-------

Environment variables LIBPROCESS_ + (IP, ADVERTISE_IP,PORT,
ADVERTISE_PORT) are now in a Flags object. Heavily inspired
by Joseph's review request [43261](https://reviews.apache.org/r/43261/).


Diffs
-----

  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 

Diff: https://reviews.apache.org/r/53559/diff/


Testing
-------

make check (macOS)


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message