mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53540: Tweaked parameter names in Mesos.
Date Mon, 07 Nov 2016 15:56:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53540/#review155142
-----------------------------------------------------------


Fix it, then Ship it!





src/common/protobuf_utils.cpp (line 385)
<https://reviews.apache.org/r/53540/#comment224976>

    I believe `containerId` would be more specific.



src/linux/capabilities.hpp (line 104)
<https://reviews.apache.org/r/53540/#comment224977>

    Seems that `processCapabilities` would be somewhat clearer (in hindsight ;).


- Benjamin Bannier


On Nov. 7, 2016, 4:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53540/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 4:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure consistency between declaration and definition. Spotted via
> clang-tidy.
> 
> 
> Diffs
> -----
> 
>   include/mesos/state/protobuf.hpp 47beb45ecb9d3486e9f8f8ce38d48264f512107d 
>   src/common/http.hpp c2398177c9e5af12c7a20c02e92d3f3036a7a39a 
>   src/common/protobuf_utils.cpp 7362b875ce1ffca6bc6376169a11494bdb9cf062 
>   src/linux/capabilities.hpp 9c0bcf46c1bf8435eabb7410961ce52828ffbfea 
>   src/log/coordinator.hpp b5f9c962a983af0d591e878d12b7fe8bb59cc867 
>   src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881 
>   src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 
>   src/slave/slave.hpp c0a17657e684e87d555731d2e35ac15894c3c05b 
>   src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 
>   src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 
> 
> Diff: https://reviews.apache.org/r/53540/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Note that there are lots of other mismatches in names between declarations and definitions,
but most of the ones I didn't fix seem to be intentional: e.g., declaring a parameter named
`t` but using `t_` in the definition (typically because the implementation assigns `t_` to
a member field named `t`).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message