mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53539: Tweaked parameter name in stout.
Date Mon, 07 Nov 2016 15:56:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53539/#review155141
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/json.hpp (line 142)
<https://reviews.apache.org/r/53539/#comment224975>

    Could you instead fixed the definitions to use `std::ostream& stream` instead? That's
what we typically use.


- Benjamin Bannier


On Nov. 7, 2016, 4:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53539/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 4:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure consistency between declaration and definition. Spotted via
> clang-tidy.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/json.hpp 9734561549eea867d57f14a0ab71febeb9dddc06 
> 
> Diff: https://reviews.apache.org/r/53539/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Note that there are lots of other mismatches in names between declarations and definitions,
but most of the ones I didn't fix seem to be intentional: e.g., declaring a parameter named
`t` but using `t_` in the definition (typically because the implementation assigns `t_` to
a member field named `t`).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message