mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53536: Avoided unnecessary copy in stout.
Date Mon, 07 Nov 2016 15:56:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53536/#review155148
-----------------------------------------------------------


Ship it!




As an aside, how did you use `support/mesos-tidy.sh` with custom `CHECKS` to find these, or
just run plain `clang-tidy` on the files in the compilation database? I am asking since stout
is a header-only library, and that with some `header-filter` there could be more issues in
header files. Or else the code is just very clean ...

- Benjamin Bannier


On Nov. 7, 2016, 4:24 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53536/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Spotted via clang-tidy.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os_tests.cpp 0b7ee0723b6a608d6f110fa8ac16e0fd7b75ddea 
> 
> Diff: https://reviews.apache.org/r/53536/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message