mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags
Date Mon, 07 Nov 2016 15:51:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52754/
-----------------------------------------------------------

(Updated Nov. 7, 2016, 3:51 p.m.)


Review request for mesos, James Peach, Michael Park, and Neil Conway.


Changes
-------

Addressed recent comments.


Bugs: MESOS-6239
    https://issues.apache.org/jira/browse/MESOS-6239


Repository: mesos


Description
-------

The hardening flags produced many new errors about unused functions, variables, etc. that
need to be fixed for Mesos to compile/run.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/profiler.hpp f6fccfb 
  3rdparty/libprocess/src/profiler.cpp 0c4949e 
  3rdparty/libprocess/src/tests/benchmarks.cpp 945007c 
  3rdparty/libprocess/src/tests/process_tests.cpp a4af54a 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62 

Diff: https://reviews.apache.org/r/52754/diff/


Testing
-------

Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make &&
make check && make bench.


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message