mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.
Date Mon, 07 Nov 2016 11:16:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 7, 2016, 12:16 p.m.)

Review request for mesos, Neil Conway and Till Toenshoff.


Added important punctuation in comment.

Bugs: MESOS-6516

Repository: mesos


We need to correctly distinguish between the environment variable
GTEST_FILTER being unset, and containing an empty string. In the first
case we want to run all tests, while in the latter none at all.

Diffs (updated)

  support/ 3e736d5a9d66faed46ac82076b08c1b72f72b8a7 



Created a failing test and confirmed it was not executed when `GTEST_FILTER=''` was set in
the environment.


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message