mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.
Date Mon, 07 Nov 2016 11:16:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53304/
-----------------------------------------------------------

(Updated Nov. 7, 2016, 12:16 p.m.)


Review request for mesos, Neil Conway and Till Toenshoff.


Changes
-------

Added important punctuation in comment.


Bugs: MESOS-6516
    https://issues.apache.org/jira/browse/MESOS-6516


Repository: mesos


Description
-------

We need to correctly distinguish between the environment variable
GTEST_FILTER being unset, and containing an empty string. In the first
case we want to run all tests, while in the latter none at all.


Diffs (updated)
-----

  support/mesos-gtest-runner.py 3e736d5a9d66faed46ac82076b08c1b72f72b8a7 

Diff: https://reviews.apache.org/r/53304/diff/


Testing
-------

Created a failing test and confirmed it was not executed when `GTEST_FILTER=''` was set in
the environment.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message