mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <armand.gril...@gmail.com>
Subject Re: Review Request 53509: Flag --master now required and parsed by MasterDetector.
Date Mon, 07 Nov 2016 08:42:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53509/
-----------------------------------------------------------

(Updated Nov. 7, 2016, 8:42 a.m.)


Review request for mesos, Joseph Wu and Till Toenshoff.


Summary (updated)
-----------------

Flag --master now required and parsed by MasterDetector.


Bugs: MESOS-2723
    https://issues.apache.org/jira/browse/MESOS-2723


Repository: mesos


Description
-------

This commit makes the --master argument mandatory.
The parsing of the argument now happens in src/master/detector.cpp.


Diffs
-----

  src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 

Diff: https://reviews.apache.org/r/53509/diff/


Testing
-------

Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with
`--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message