mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53509: Flag —master now required and parsed by MasterDetector.
Date Sat, 05 Nov 2016 04:26:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53509/#review155047
-----------------------------------------------------------



Bad patch!

Reviews applied: [53509]

Failed command: ./support/apply-review.sh -n -r 53509

Error:
2016-11-05 04:26:27 URL:https://reviews.apache.org/r/53509/diff/raw/ [1539/1539] -> "53509.patch"
[1]
Traceback (most recent call last):
  File "support/apply-reviews.py", line 342, in <module>
    reviewboard()
  File "support/apply-reviews.py", line 321, in reviewboard
    apply_review()
  File "support/apply-reviews.py", line 139, in apply_review
    commit_patch()
  File "support/apply-reviews.py", line 180, in commit_patch
    data = patch_data()
  File "support/apply-reviews.py", line 199, in patch_data
    return reviewboard_data()
  File "support/apply-reviews.py", line 258, in reviewboard_data
    review_url=url)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2014' in position 5: ordinal
not in range(128)

Full log: https://builds.apache.org/job/mesos-reviewbot/15956/console

- Mesos ReviewBot


On Nov. 5, 2016, 12:51 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53509/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Till Toenshoff.
> 
> 
> Bugs: MESOS-2723
>     https://issues.apache.org/jira/browse/MESOS-2723
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit makes the --master argument mandatory.
> The parsing of the argument now happens in src/master/detector.cpp.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp b265bc6390ed8329a200408ef45512f900f9b999 
> 
> Diff: https://reviews.apache.org/r/53509/diff/
> 
> 
> Testing
> -------
> 
> Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent
with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message