mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53483: Added members type/reader to `Request`.
Date Sat, 05 Nov 2016 00:58:20 GMT


> On Nov. 5, 2016, 12:54 a.m., Benjamin Mahler wrote:
> >

Also can you clarify the commit summary for those that don't have context?

For example: "Introduced a PIPE-type http::Request to support streaming requests."

With this I can tell what the intention is.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53483/#review155033
-----------------------------------------------------------


On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53483/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 5:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
>     https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These new members are needed for supporting request streaming i.e.,
> the caller can use the writer to stream chunks to the server if
> the request body is not known in advance.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9722c6210526479da243ae9945e4c9a89ecb9009

> 
> Diff: https://reviews.apache.org/r/53483/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message