mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53482: Initialized the POD type in the `Request` struct.
Date Sat, 05 Nov 2016 00:34:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53482/#review155031
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/include/process/http.hpp (lines 434 - 437)
<https://reviews.apache.org/r/53482/#comment224860>

    Maybe something more like an additional TODO:
    
    ```
    // TODO(anand): Ideally this could default to 'true' since
    // persistent connections are the default since HTTP 1.1.
    // Perhaps we need to go from `keepAlive` to `closeConnection`
    // to reflect the header more accurately, and to have an
    // intuitive default of false.
    ```
    
    I noticed go stores this variable as `Close` which means the intuitive default (false)
makes sense.


- Benjamin Mahler


On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53482/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 5:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
>     https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the `keepAlive` member was not initialized correctly,
> the behavior is undefined if POD types are not correctly
> initialized.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9722c6210526479da243ae9945e4c9a89ecb9009

> 
> Diff: https://reviews.apache.org/r/53482/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message