mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53481: Moved around the `Request` struct in the file.
Date Sat, 05 Nov 2016 00:21:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53481/#review155030
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53481/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 5:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6466
>     https://issues.apache.org/jira/browse/MESOS-6466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This serves two purposes:
> - This brings it near the `Response` struct thereby making it easy
> to switch between them for readability.
> - In the future, `Request` would have a `Pipe::Reader` member
> for supporting request streaming. Otherwise, we would need to
> add another forward declaration and forward declaring nested
> structs is not quite possible.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9722c6210526479da243ae9945e4c9a89ecb9009

> 
> Diff: https://reviews.apache.org/r/53481/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message