mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 52735: Removed TODO message for docker killing.
Date Sat, 05 Nov 2016 00:04:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/#review155025
-----------------------------------------------------------



Can you make this as the first patch for the patch chain?


src/slave/containerizer/docker.cpp 
<https://reviews.apache.org/r/52735/#comment224853>

    Instead of killing this directly, can you please update the comments a bit and move it
right before #2213
    
    ```
    // We've failed to do a Docker::kill, which means that the
    // container is still running! Here we invoke `Self::remove`
    // after `docker_remove_delay` to force remove the docker
    // container again.
    ```


- Guangya Liu


On 十一月 2, 2016, 7:29 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52735/
> -----------------------------------------------------------
> 
> (Updated 十一月 2, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed TODO message for docker killing.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 
> 
> Diff: https://reviews.apache.org/r/52735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message