mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 53465: Fixed the container status for nested containers.
Date Fri, 04 Nov 2016 07:07:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53465/
-----------------------------------------------------------

Review request for mesos, Kevin Klues and Vinod Kone.


Bugs: MESOS-6465 and MESOS-6528
    https://issues.apache.org/jira/browse/MESOS-6465
    https://issues.apache.org/jira/browse/MESOS-6528


Repository: mesos


Description
-------

Prior to this patch, the ContainerStatus inside the TaskStatus for a
task in the default executor is not correct. The agent always gets the
container status of the top level container, even if the task might
correspond to a nested container.

This patch fixed this issue by letting the executor set the container
ID for the task (because only it has the knowledge about this
mapping), and the agent will use that container ID to get the proper
container status.


Diffs
-----

  src/launcher/default_executor.cpp b8a88ad6e361720dc7d02c9423db3e67226f779f 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2f6723c64261fb3295626d6479fe844fb23b0650

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 939142e36b926d9e4201d35dedd25e32e9f8c63c

  src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 

Diff: https://reviews.apache.org/r/53465/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message