mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Review Request 53459: Refactored `Socket` to support a templated version.
Date Fri, 04 Nov 2016 06:41:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53459/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Jie Yu.


Repository: mesos


Description
-------

The templated `Socket` will enable us to provide type safe
functionality for different addresses, ultimately `inet::Address` and
`unix::Address` (and likely eventually `inet6::Address` as well).

Also introduced the `inet` namespace and updated the code to
explicitly use `inet::Address` and `inet::Socket`.


Diffs
-----

  3rdparty/libprocess/include/process/address.hpp 04e3155d65f476208fa852e83b79d173b66288fd

  3rdparty/libprocess/include/process/firewall.hpp ad461caaa95c1098d5449307b0c07508e22c3c37

  3rdparty/libprocess/include/process/http.hpp 9722c6210526479da243ae9945e4c9a89ecb9009 
  3rdparty/libprocess/include/process/pid.hpp 36453b600c91c2ddc057db15ec5938e6c819260b 
  3rdparty/libprocess/include/process/process.hpp f389d3d3b671e301a7ac911ad87ab13289e8c82f

  3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f

  3rdparty/libprocess/include/process/ssl/gtest.hpp 21a0fc45b55a368a21b3e616c751ab43eebd4902

  3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36 
  3rdparty/libprocess/src/encoder.hpp 005d1cc36d7a4c0b57fba28cf7bd2ff9f71772e4 
  3rdparty/libprocess/src/http.cpp b5ddac9f1970358f8232a481431507242052d294 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp acb00d41c637a318b2f16fff9e97998b9c79b809

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 21f878ee81db32ad35878ec053c3f2de3637196c

  3rdparty/libprocess/src/pid.cpp f9313cde006dd067be265343eed60412ad6b0b95 
  3rdparty/libprocess/src/poll_socket.hpp d04f3f2d1bcf70464ac659b29f96574bbd233414 
  3rdparty/libprocess/src/poll_socket.cpp f0ee1490e6fccb038f64a27b2c71458ad5b5e5a1 
  3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d 
  3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614312373b0515025f09f9f8495f9ce353a3

  3rdparty/libprocess/src/tests/http_tests.cpp 533104c93dd1eaf67bf3752163d2e0cad090078d 
  3rdparty/libprocess/src/tests/process_tests.cpp a4af54aa78c162bc0ecbe2f25796d8c9b12e0f31

  3rdparty/libprocess/src/tests/ssl_client.cpp 8d62fc2975b585013a8d9a6efc967314d6d8ec47 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 55c8c309571b1892b0acc4d766eda9bb98085a6f 
  3rdparty/libprocess/src/tests/test_linkee.cpp 1f6cfafcb73fd41ef350b13e3ac6023d78f16f5a 

Diff: https://reviews.apache.org/r/53459/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message