mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 53455: Fixed the TestContainerizer to be thread-safe.
Date Fri, 04 Nov 2016 06:15:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53455/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Bugs: MESOS-6544 and MESOS-6545
    https://issues.apache.org/jira/browse/MESOS-6544
    https://issues.apache.org/jira/browse/MESOS-6545


Repository: mesos


Description
-------

The TestContainerizer is currently not backed by a Process and
does not do any explicit synchronization and so is not thread safe.

Most tests currently cannot trip the concurrency issues, but
this surfaced recently in MESOS-6544.


Diffs
-----

  src/tests/containerizer.hpp d418ecebee155f894187e24549f42497372d8a5f 
  src/tests/containerizer.cpp c2208660352e5cf62cec5c7b92ec67fea62aea49 

Diff: https://reviews.apache.org/r/53455/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message