mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52667: Added mesos test helper 'createCommandInfo()'.
Date Fri, 04 Nov 2016 04:20:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52667/#review154858
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp (lines 1028 - 1035)
<https://reviews.apache.org/r/52667/#comment224616>

    Why change those?


- Jie Yu


On Nov. 4, 2016, 12:31 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52667/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 12:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new parameter 'arguments' for non-shell command.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 45dba233d9db39ead5f562e8090d07b5e0c6d42d 
> 
> Diff: https://reviews.apache.org/r/52667/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message