mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52718: Added mesos v1 test helper 'v1::createCallAccept()'.
Date Fri, 04 Nov 2016 00:38:37 GMT


> On Oct. 10, 2016, 7:56 p.m., Anand Mazumdar wrote:
> > src/tests/mesos.hpp, lines 957-971
> > <https://reviews.apache.org/r/52718/diff/1/?file=1530159#file1530159line957>
> >
> >     We won't need this if we add an action `LaunchTasks` as per my earlier comment.

We use driver->launchTasks more often than LaunchTasks currently in our tests. Let's use
mesos-send() for task and taskgroupinfo explicitly.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52718/#review152093
-----------------------------------------------------------


On Nov. 3, 2016, 5:38 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52718/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 5:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mesos v1 test helper 'v1::createCallAccept()'.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 45dba233d9db39ead5f562e8090d07b5e0c6d42d 
> 
> Diff: https://reviews.apache.org/r/52718/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message