mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Robinson <drobin...@twopensource.com>
Subject Re: Review Request 53411: Use a random TCP port for framework tests.
Date Thu, 03 Nov 2016 22:39:08 GMT


> On Nov. 3, 2016, 8:16 p.m., Vinod Kone wrote:
> > src/tests/balloon_framework_test.sh, line 73
> > <https://reviews.apache.org/r/53411/diff/1/?file=1552377#file1552377line73>
> >
> >     why did you pick these particular numbers?

Chosen at random; we could use anything between 1024 and 65535.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53411/#review154795
-----------------------------------------------------------


On Nov. 2, 2016, 11:43 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53411/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-6537
>     https://issues.apache.org/jira/browse/MESOS-6537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use a random TCP port for framework tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/balloon_framework_test.sh 7d0a4fee200577a5f7b2edbb3b310a07678879dd 
>   src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e 
> 
> Diff: https://reviews.apache.org/r/53411/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, ensured the test succeeded and the port wasn't 5432.
> 
> DEBUG: [ RUN      ] ExamplesTest.DiskFullFramework
> ...
> DEBUG: I1102 22:39:12.339356 46828 master.cpp:380] Master 550c3c82-063a-427d-b130-60044fbd4898
(localhost) started on 127.0.0.1:24269
> ...
> DEBUG: I1102 22:39:14.312568 46937 slave.cpp:915] New master detected at master@127.0.0.1:24269
> ...
> DEBUG: [       OK ] ExamplesTest.DiskFullFramework (17988 ms)
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message