mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.
Date Thu, 03 Nov 2016 16:59:33 GMT


> On Nov. 3, 2016, 3:57 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp, line 3921
> > <https://reviews.apache.org/r/53385/diff/2/?file=1552100#file1552100line3921>
> >
> >     I'm surprised to find out that we don't have `DockerExecutorTest` fixture!

There's a `DockerContainerizerTest` fixture, and the `TearDown` method removes the Docker
containers =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53385/#review154713
-----------------------------------------------------------


On Nov. 3, 2016, 4:58 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53385/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 4:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6457
>     https://issues.apache.org/jira/browse/MESOS-6457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to ensure MESOS-6457 is fixed for the Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 810488d1476cadbbd5a4a7dcecaeec55739ab71f

> 
> Diff: https://reviews.apache.org/r/53385/diff/
> 
> 
> Testing
> -------
> 
> See summary.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message