mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53407: Fixed the Docker executor to not generate RUNNING after KILLING.
Date Thu, 03 Nov 2016 16:05:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53407/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 4:05 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Bugs: MESOS-6457
    https://issues.apache.org/jira/browse/MESOS-6457


Repository: mesos


Description
-------

The Docker executor would send health updates even after having
transitioned a task to `TASK_KILLING`. This plus the fact that health
updates always have the `TASK_RUNNING` state leads to `TASK_KILLING ->
TASK_RUNNING` transitions.

This patch makes the executor skip health updates after starting to kill
a task.


Diffs
-----

  src/docker/executor.cpp 749e590f73ad0da94599858c8430331378d39418 

Diff: https://reviews.apache.org/r/53407/diff/


Testing
-------

Test in the next patch in the chain.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message