mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.
Date Thu, 03 Nov 2016 15:51:21 GMT


> On Nov. 3, 2016, 3:36 p.m., Alexander Rukletsov wrote:
> > src/tests/command_executor_tests.cpp, line 259
> > <https://reviews.apache.org/r/53406/diff/1/?file=1552096#file1552096line259>
> >
> >     ash? : )

`ash` is a shell that comes with some linux distros and with Busybox, not a typo =). See:
http://stackoverflow.com/questions/11280240/why-my-trap-doesnt-work-when-the-signal-set-as-debug-fake-signal


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53406/#review154712
-----------------------------------------------------------


On Nov. 3, 2016, 3:51 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53406/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 3:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to ensure MESOS-6457 is fixed for the command executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062 
> 
> Diff: https://reviews.apache.org/r/53406/diff/
> 
> 
> Testing
> -------
> 
> Verified that the test fails without 53378 on both macOS and Linux, but passes with it.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message