mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53304: Fixed parallel test runner for empty GTEST_FILTER.
Date Thu, 03 Nov 2016 10:31:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53304/#review154698
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53304]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 3, 2016, 9:18 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53304/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 9:18 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-6516
>     https://issues.apache.org/jira/browse/MESOS-6516
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need to correctly distinguish between the environment variable
> GTEST_FILTER being unset, and containing an empty string. In the first
> case we want to run all tests, while in the latter none at all.
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 457211a7721a1595a8efaf51a10041da0494bdfe 
> 
> Diff: https://reviews.apache.org/r/53304/diff/
> 
> 
> Testing
> -------
> 
> Created a failing test and confirmed it was not executed when `GTEST_FILTER=''` was set
in the environment.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message