mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53387: Silenced some `clang-tidy` warnings in test cases.
Date Thu, 03 Nov 2016 04:27:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53387/#review154673
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53386, 53387]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 2, 2016, 4:24 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53387/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `clang-tidy` points out, rightly, that an `ASSERT` failure can result in
> leaking some heap-allocated values that aren't wrapped in a smart
> pointer. This commit fixes the cases that `clang-tidy` complains about
> by wrapping the values in `Owned<T>`.
> 
> Note that there are many other places in the tests that leak resources
> if an exception occurs. The proper fix is usually to use a smart pointer
> rather than a raw pointer. However, this is not always easy/clean, in
> part because the current `Owned<T>` and `Shared<T>` types do not support
> inheritance (MESOS-6496). So for now, just fix the cases that clang-tidy
> complains about.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 4df537747d84daa68c29e2d05b22fa386a4a16db

> 
> Diff: https://reviews.apache.org/r/53387/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Verified that observed `clang-tidy` warnings go away with this change.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message