mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.
Date Thu, 03 Nov 2016 00:12:49 GMT


> On Oct. 26, 2016, 3:22 a.m., Kevin Klues wrote:
> > src/slave/containerizer/docker.cpp, line 723
> > <https://reviews.apache.org/r/50599/diff/15/?file=1543834#file1543834line723>
> >
> >     Can you just use `stringify()` here? Also, can you use `Path().join()` instead
of just `+`.
> 
> Yubo Li wrote:
>     I changed the code to `path::join(nvidiaDataPrefix, stringify(gpu.minor));`, but
the output path becomes `/dev/nvidia/0`, not `/dev/nvidia0` we are expected. So that I keeped
`+` instead of `path::join()`.

Yeah, that makes sense. A '+' is actually the correct thing here afterall.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review153839
-----------------------------------------------------------


On Nov. 2, 2016, 7:28 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50599/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 7:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Assigned Nvidia GPU devices to docker container based on
> GPUs allocated by Nvidia GPU allocator.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 
> 
> Diff: https://reviews.apache.org/r/50599/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message