mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
Date Thu, 03 Nov 2016 00:10:25 GMT


> On Oct. 26, 2016, 3:22 a.m., Kevin Klues wrote:
> > src/slave/containerizer/docker.cpp, line 2161
> > <https://reviews.apache.org/r/50841/diff/17/?file=1543830#file1543830line2161>
> >
> >     Maybe consider using a ":" here instead of a comma?
> 
> Guangya Liu wrote:
>     After a second thought, I'm not sure if using a ":" is better than a comma here.
>     
>     With ":", one example message would be
>     ```
>     Failed to kill the Docker container: discarded future: 1 GPUs leaked
>     ```
>     
>     With comma, one example message would be:
>     ```
>     Failed to kill the Docker container: discarded future, 1 GPUs leaked
>     ```
>     
>     Seems comma is better?
> 
> Yubo Li wrote:
>     Yes, I think comma is better :)

I agree, a comma looks better here.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/#review153837
-----------------------------------------------------------


On Nov. 2, 2016, 7:26 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50841/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 7:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added control logic to allocate/deallocate GPUs to GPU-related task
> when the task is started/terminated.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 
> 
> Diff: https://reviews.apache.org/r/50841/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message