mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53389: Used `MasterInfo.address` to generate the leader information.
Date Thu, 03 Nov 2016 00:05:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53389/#review154657
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53389]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 2, 2016, 5:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53389/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 5:09 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6534
>     https://issues.apache.org/jira/browse/MESOS-6534
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since `MasterInfo.hostname` and `MasterInfo.port` are deprecated, uses
> `MasterInfo.address` to generate the leader information in WebUI.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/webui/master/static/home.html 4109e89e783aa75beb83c1d3affbdf3ec4230bc2 
>   src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9

> 
> Diff: https://reviews.apache.org/r/53389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message