mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53380: Moved Mesos specific build target definition into Mesos CMakeFile.
Date Wed, 02 Nov 2016 23:08:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53380/#review154652
-----------------------------------------------------------


Fix it, then Ship it!





src/CMakeLists.txt (lines 521 - 524)
<https://reviews.apache.org/r/53380/#comment224280>

    These probably belong under this file: https://github.com/apache/mesos/blob/2e92da6d8b71bdcaccb5207839e640f96ff45ef9/cmake/MesosConfigure.cmake#L94-L95


- Joseph Wu


On Nov. 2, 2016, 8:39 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53380/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Alex Clemmer, and Joseph
Wu.
> 
> 
> Bugs: MESOS-6309
>     https://issues.apache.org/jira/browse/MESOS-6309
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 
> 
> Diff: https://reviews.apache.org/r/53380/diff/
> 
> 
> Testing
> -------
> 
> cmake ..;make (+functional check)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message