mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <>
Subject Re: Review Request 52696: Harden stout
Date Tue, 01 Nov 2016 19:10:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 1, 2016, 7:10 p.m.)

Review request for mesos, James Peach, Michael Park, and Neil Conway.


Only use `-fstack-protector-strong` when it's available. Remove `-Werror` and tackle this
in another discussion/JIRA.

Bugs: MESOS-6229

Repository: mesos


Use a default set of flags to provide additional security and hardening to stout. Additionally,
check and catch more warnings/errors.

Diffs (updated)

  3rdparty/stout/ 4e10ae2 
  3rdparty/stout/ cbb0fdb 



Compared the benchmarks with and without the flags being used. Also did a comparsion with
the flags being used with and without optimizations and without the flags being used with
and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.


Aaron Wood

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message