mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 53138: Fix libprocess build option argument handling.
Date Tue, 01 Nov 2016 16:40:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53138/#review154414
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53136, 53137, 53138]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 1, 2016, 4:24 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53138/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: MESOS-2537
>     https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix all the AC_ARG_ENABLED options to correctly handle --enable-foo
> and --disable-foo variants. Update all the invocations to have a
> consistent calling convention.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 1644035d7fe1a45c798b13dbfb3c66f74466f2a2 
> 
> Diff: https://reviews.apache.org/r/53138/diff/
> 
> 
> Testing
> -------
> 
> Make check on OS X and Fedora 24.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message