From reviews-return-48889-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 27 17:05:04 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD9CC19D09 for ; Thu, 27 Oct 2016 17:05:04 +0000 (UTC) Received: (qmail 29406 invoked by uid 500); 27 Oct 2016 17:05:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29381 invoked by uid 500); 27 Oct 2016 17:05:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29354 invoked by uid 99); 27 Oct 2016 17:05:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 17:05:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 34BEF25BCDF; Thu, 27 Oct 2016 17:05:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3237155098046047647==" MIME-Version: 1.0 Subject: Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags From: Aaron Wood To: Neil Conway , Michael Park , James Peach Cc: Aaron Wood , mesos Date: Thu, 27 Oct 2016 17:05:03 -0000 Message-ID: <20161027170503.8172.99533@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aaron Wood X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52886/ X-Sender: Aaron Wood References: <20161017153950.5284.66675@reviews.apache.org> In-Reply-To: <20161017153950.5284.66675@reviews.apache.org> Reply-To: Aaron Wood X-ReviewRequest-Repository: mesos --===============3237155098046047647== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 17, 2016, 3:39 p.m., James Peach wrote: > > 3rdparty/stout/tests/ip_tests.cpp, line 50 > > > > > > Probably better to just use the same type here. Since ``network.get().prefix()`` returns ``int``, consider ``numify(prefix).get()``. Good idea! - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review152886 ----------------------------------------------------------- On Oct. 21, 2016, 6:29 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52886/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 6:29 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6239 > https://issues.apache.org/jira/browse/MESOS-6239 > > > Repository: mesos > > > Description > ------- > > The hardening flags produced many new sign comparison errors in stout that need to be fixed for Mesos to compile/run. > > > Diffs > ----- > > 3rdparty/stout/tests/cache_tests.cpp 0950c85 > 3rdparty/stout/tests/flags_tests.cpp 94ba915 > 3rdparty/stout/tests/hashmap_tests.cpp 2626d67 > 3rdparty/stout/tests/hashset_tests.cpp 66e59db > 3rdparty/stout/tests/ip_tests.cpp 59e69a5 > 3rdparty/stout/tests/json_tests.cpp 2bc4c88 > 3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 > 3rdparty/stout/tests/multimap_tests.cpp 488991b > 3rdparty/stout/tests/os/process_tests.cpp 4977d02 > 3rdparty/stout/tests/os/sendfile_tests.cpp e221689 > 3rdparty/stout/tests/os/systems_tests.cpp 110ba5b > 3rdparty/stout/tests/os_tests.cpp 6a7b836 > 3rdparty/stout/tests/strings_tests.cpp 7dd3301 > > Diff: https://reviews.apache.org/r/52886/diff/ > > > Testing > ------- > > Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make && make check && make bench. > > > Thanks, > > Aaron Wood > > --===============3237155098046047647==--