From reviews-return-48828-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Oct 27 02:12:44 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0C7419E0C for ; Thu, 27 Oct 2016 02:12:43 +0000 (UTC) Received: (qmail 6542 invoked by uid 500); 27 Oct 2016 02:12:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 6514 invoked by uid 500); 27 Oct 2016 02:12:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 6493 invoked by uid 99); 27 Oct 2016 02:12:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 02:12:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 930BB25BC96; Thu, 27 Oct 2016 02:12:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8640197804320895876==" MIME-Version: 1.0 Subject: Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps. From: Mesos ReviewBot To: Neil Conway , "\(Disabled_DoNotUse\) Anindya Sinha" , Megha Sharma Cc: Mesos ReviewBot , Jiang Yan Xu , mesos Date: Thu, 27 Oct 2016 02:12:42 -0000 Message-ID: <20161027021242.9386.54620@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53208/ X-Sender: Mesos ReviewBot References: <20161026230636.9387.9857@reviews.apache.org> In-Reply-To: <20161026230636.9387.9857@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============8640197804320895876== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/#review153973 ----------------------------------------------------------- Patch looks great! Reviews applied: [53208] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 26, 2016, 11:06 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53208/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 11:06 p.m.) > > > Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Megha Sharma, and Neil Conway. > > > Bugs: MESOS-4975 and MESOS-6482 > https://issues.apache.org/jira/browse/MESOS-4975 > https://issues.apache.org/jira/browse/MESOS-6482 > > > Repository: mesos > > > Description > ------- > > This has also caused CHECK failures mentioned in MESOS-6482. > > > Diffs > ----- > > src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 > > Diff: https://reviews.apache.org/r/53208/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > > --===============8640197804320895876==--