From reviews-return-47461-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Oct 10 05:01:04 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1EE1319D47 for ; Mon, 10 Oct 2016 05:01:04 +0000 (UTC) Received: (qmail 13544 invoked by uid 500); 10 Oct 2016 05:01:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 13517 invoked by uid 500); 10 Oct 2016 05:01:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 13496 invoked by uid 99); 10 Oct 2016 05:01:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Oct 2016 05:01:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2E6F12D77ED; Mon, 10 Oct 2016 05:01:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6234262984457699259==" MIME-Version: 1.0 Subject: Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible. From: Guangya Liu To: Benjamin Mahler , Jacob Janco , Jiang Yan Xu Cc: Mesos ReviewBot , Guangya Liu , mesos Date: Mon, 10 Oct 2016 05:01:02 -0000 Message-ID: <20161010050102.23091.37596@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Guangya Liu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51621/ X-Sender: Guangya Liu References: <20160928033851.21738.86064@reviews.apache.org> In-Reply-To: <20160928033851.21738.86064@reviews.apache.org> Reply-To: Guangya Liu X-ReviewRequest-Repository: mesos --===============6234262984457699259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/ ----------------------------------------------------------- (Updated 十月 10, 2016, 5:01 a.m.) Review request for mesos, Benjamin Mahler, Jacob Janco, and Jiang Yan Xu. Changes ------- Rebase Bugs: MESOS-3078 https://issues.apache.org/jira/browse/MESOS-3078 Repository: mesos Description (updated) ------- Please do not review for now as it is WIP. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.cpp c8f9492ee1b69e125a1e841116d22a578a9b524e src/tests/hierarchical_allocator_tests.cpp 7957873102b3777d47fa9304b85a93d58a746b9d src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb src/tests/oversubscription_tests.cpp b356fb62a4e068bc171a75a76001c6d0e76af92a src/tests/persistent_volume_tests.cpp e10a79e9662530e143ccaa2aa2506a4d25158364 src/tests/reservation_endpoints_tests.cpp 7d271085d822e85d27cea5361bfee0d0d91a5691 src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 src/tests/slave_tests.cpp bb6216f3f608ce8620a3a11ca716389a906f2d26 Diff: https://reviews.apache.org/r/51621/diff/ Testing ------- make make check ``` GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*" --verbose --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.GoodACL*/*" --verbose --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.UnreserveAvailableAndOfferedResources" --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.ReserveAvailableAndOfferedResources" --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationTest.ACLMultipleOperations" --verbose --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/1.RebalancedForUpdatedWeights" --gtest_repeat=30 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.UpdateWeight" --verbose --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/*.SlaveLost" --gtest_repeat=20 GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="SlaveTest.ExecutorShutdownGracePeriod" --gtest_repeat=20 ``` Thanks, Guangya Liu --===============6234262984457699259==--