From reviews-return-47452-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Oct 9 10:17:01 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 043B219255 for ; Sun, 9 Oct 2016 10:17:01 +0000 (UTC) Received: (qmail 76292 invoked by uid 500); 9 Oct 2016 10:17:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 76265 invoked by uid 500); 9 Oct 2016 10:17:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 76241 invoked by uid 99); 9 Oct 2016 10:16:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Oct 2016 10:16:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E09152C9B87; Sun, 9 Oct 2016 10:16:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4526174858050957069==" MIME-Version: 1.0 Subject: Re: Review Request 50123: Added GPU scheduler for docker containerizer process. From: Guangya Liu To: Kevin Klues , Benjamin Mahler , Rajat Phull Cc: mesos , Guangya Liu , Yubo Li Date: Sun, 09 Oct 2016 10:16:57 -0000 Message-ID: <20161009101657.23091.54799@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Guangya Liu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50123/ X-Sender: Guangya Liu References: <20160922060948.1653.19931@reviews.apache.org> In-Reply-To: <20160922060948.1653.19931@reviews.apache.org> Reply-To: Guangya Liu X-ReviewRequest-Repository: mesos --===============4526174858050957069== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review151936 ----------------------------------------------------------- src/slave/containerizer/docker.hpp (line 76) This will cause build failed on Mac OS as `NvidiaGpuAllocator` was only defined in linux https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp#L21 I think that you can follow the same way as we did for `NvidiaComponents` https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp#L27 - Guangya Liu On 九月 22, 2016, 6:09 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 九月 22, 2016, 6:09 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer process so that > docker containerizer process is ready to use it to allocate GPUs to task > with 'gpus' resource. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 > src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 > src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > > --===============4526174858050957069==--