mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.
Date Thu, 27 Oct 2016 20:33:02 GMT


> On Oct. 17, 2016, 6:22 p.m., Neil Conway wrote:
> > docs/shared-resources.md, line 168
> > <https://reviews.apache.org/r/52934/diff/1/?file=1539702#file1539702line168>
> >
> >     I think we should discuss what happens if you try to write to a read-only volume.
> 
> Jiang Yan Xu wrote:
>     SG.

We only allow persistent volumes as `RW`, they can never exist as `RO` (as in `Option<Error>
validatePersistentVolume(const RepeatedPtrField<Resource>& volumes)`. MESOS-6374
once implemented would not require `Resource::DiskInfo::Volume` to be included while doing
a `CREATE` of persistent volumes (mode shall default to `RW`).

Tasks can request through the resources in `LAUNCH` if it wishes to use the volume as `RO`
or `RW`. In case the task tries to write to a persistent volume it had requested `RO` access
for, the task fails. Is there any other potential usage behavior that can be incorporated
here as far as the task is concerned?


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52934/#review152923
-----------------------------------------------------------


On Oct. 17, 2016, 6:15 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52934/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Explain read-only mode of persistent volumes in shared-resources.md.
> 
> 
> Diffs
> -----
> 
>   docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 
> 
> Diff: https://reviews.apache.org/r/52934/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message