mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.
Date Thu, 27 Oct 2016 20:27:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53208/
-----------------------------------------------------------

(Updated Oct. 27, 2016, 1:27 p.m.)


Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Benjamin Mahler, Megha Sharma,
and Neil Conway.


Bugs: MESOS-4975 and MESOS-6482
    https://issues.apache.org/jira/browse/MESOS-4975
    https://issues.apache.org/jira/browse/MESOS-6482


Repository: mesos


Description
-------

This has also caused CHECK failures mentioned in MESOS-6482.


Diffs
-----

  src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 

Diff: https://reviews.apache.org/r/53208/diff/


Testing (updated)
-------

make check

MESOS-6482 exposes a CHECK failure which is going to be removed in /r/53202/, given that I
just modified the `PartitionTest.DisconnectedFramework` to do a one-off verification: when
the slave is marked unreachable after the framework is destroyed, without this patch the CHECK
failure in MESOS-6482 occurs and with the patch it doesn't.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message