mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 53234: Logged warning message if reading previous boot ID fails.
Date Thu, 27 Oct 2016 18:39:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53234/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-5396
    https://issues.apache.org/jira/browse/MESOS-5396


Repository: mesos


Description
-------

Not much we can do here, but as a general rule, we should never silently
ignore I/O errors.


Diffs
-----

  src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 

Diff: https://reviews.apache.org/r/53234/diff/


Testing
-------

`make check`

Tested manually by doing `chmod 000` of the boot-id file.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message