mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 53233: Simplified `State::recover` interface in the agent.
Date Thu, 27 Oct 2016 18:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53233/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-5396
    https://issues.apache.org/jira/browse/MESOS-5396


Repository: mesos


Description
-------

`State::recover` previously returned `Result<State>`, which implied
three possibilities: Error, None (if the `work_dir` doesn't exist), or a
`State` value. However, the agent code treated the latter two cases the
same way: if the `work_dir` doesn't exist, it is simpler to represent
this case by returning a `State` value whose fields are `None()`.


Diffs
-----

  src/slave/slave.hpp c0a17657e684e87d555731d2e35ac15894c3c05b 
  src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 
  src/slave/state.hpp a1c849690a5c2b3fc5ea3eb2e782e99a2b0f8044 
  src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 

Diff: https://reviews.apache.org/r/53233/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message