mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 53084: Updated the env variable used to enable SSL.
Date Thu, 27 Oct 2016 14:11:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53084/#review154012
-----------------------------------------------------------




src/launcher/default_executor.cpp (line 1037)
<https://reviews.apache.org/r/53084/#comment223533>

    Within `3rdparty/libprocess/src/openssl.cpp` you will see that we actually take precedence
on the `SSL_` variant over the `LIBPROCESS_SSL_` variant. In case of conflicts we are warning
the user within `reinitialize`. Have a look at that logic please and see if you can play along
a bit more in line.


- Till Toenshoff


On Oct. 24, 2016, 9:05 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53084/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 9:05 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till Toenshoff,
and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According to the documentation it is `LIBPROCESS_SSL_ENABLED`, not
> `SSL_ENABLED`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 
>   src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d 
> 
> Diff: https://reviews.apache.org/r/53084/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message