mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.
Date Thu, 27 Oct 2016 01:59:26 GMT


> On Oct. 27, 2016, 1:34 a.m., Joseph Wu wrote:
> > src/cli_new/bin/mesos-cli-tests, line 5
> > <https://reviews.apache.org/r/51008/diff/7/?file=1542468#file1542468line5>
> >
> >     This isn't always true, as my build folder could be named anything.
> >     
> >     If you need to depend on some build artifacts (like `bin/mesos-agent`), it would
be better to add this script as a template (`bin/mesos-cli-tests.sh.in`) and then `AC_CONFIG_FILES(...)`
it.
> >     
> >     If you go that route, then `tests.py` would probably be templatized too.

This just sets the default to "${CURRDIR}/../../../build"}. You can override it with whatever
you want by setting the BUILD_DIR environment variable before you call the script (which I
do in Makefile.am in a subsequent commit).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51008/#review153936
-----------------------------------------------------------


On Oct. 20, 2016, 6:12 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51008/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6032
>     https://issues.apache.org/jira/browse/MESOS-6032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added infrastructure for unit tests in the new python-based CLI.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/mesos-cli-tests PRE-CREATION 
>   src/cli_new/bin/tests.py PRE-CREATION 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
> 
> Diff: https://reviews.apache.org/r/51008/diff/
> 
> 
> Testing
> -------
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message