mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.
Date Wed, 26 Oct 2016 23:09:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53208/#review153961
-----------------------------------------------------------




src/master/master.cpp (line 2482)
<https://reviews.apache.org/r/53208/#comment223453>

    Would you mind also moving these to use `.at()` instead of `[]` since they are trying
to perform const access?
    
    We've slowly been trying to move const accesses to `.at()` to prevent these kinds of issues.


- Benjamin Mahler


On Oct. 26, 2016, 11:06 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53208/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2016, 11:06 p.m.)
> 
> 
> Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Megha Sharma, and Neil Conway.
> 
> 
> Bugs: MESOS-4975 and MESOS-6482
>     https://issues.apache.org/jira/browse/MESOS-4975
>     https://issues.apache.org/jira/browse/MESOS-6482
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This has also caused CHECK failures mentioned in MESOS-6482.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 
> 
> Diff: https://reviews.apache.org/r/53208/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message