mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags
Date Mon, 17 Oct 2016 15:39:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52886/#review152886
-----------------------------------------------------------




3rdparty/stout/tests/ip_tests.cpp (line 50)
<https://reviews.apache.org/r/52886/#comment222067>

    Probably better to just use the same type here. Since ``network.get().prefix()`` returns
``int``, consider ``numify<int>(prefix).get()``.



3rdparty/stout/tests/os/sendfile_tests.cpp (line 70)
<https://reviews.apache.org/r/52886/#comment222069>

    I'd be inclined to cast this the other way to preserve the ``-1`` return value from ``read(2)``,
ie. ``static_cast<ssize_t>(LOREM_IPSUM.size())``.
    
    Same comment for checking the ``sendfile(2)`` return value.


- James Peach


On Oct. 14, 2016, 3:19 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52886/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 3:19 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-6239
>     https://issues.apache.org/jira/browse/MESOS-6239
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The hardening flags produced many new sign comparison errors in stout that need to be
fixed for Mesos to compile/run.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/cache_tests.cpp 0950c85 
>   3rdparty/stout/tests/flags_tests.cpp 94ba915 
>   3rdparty/stout/tests/hashmap_tests.cpp 2626d67 
>   3rdparty/stout/tests/hashset_tests.cpp 66e59db 
>   3rdparty/stout/tests/ip_tests.cpp 59e69a5 
>   3rdparty/stout/tests/json_tests.cpp 2bc4c88 
>   3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 
>   3rdparty/stout/tests/multimap_tests.cpp 488991b 
>   3rdparty/stout/tests/os/process_tests.cpp 4977d02 
>   3rdparty/stout/tests/os/sendfile_tests.cpp e221689 
>   3rdparty/stout/tests/os/systems_tests.cpp 110ba5b 
>   3rdparty/stout/tests/os_tests.cpp 6a7b836 
>   3rdparty/stout/tests/strings_tests.cpp 7dd3301 
> 
> Diff: https://reviews.apache.org/r/52886/diff/
> 
> 
> Testing
> -------
> 
> Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make
&& make check && make bench.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message