mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yubo Li <liyub...@cn.ibm.com>
Subject Re: Review Request 50123: Added GPU scheduler for docker containerizer process.
Date Wed, 12 Oct 2016 06:44:25 GMT


> On 十月 9, 2016, 10:16 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.hpp, line 76
> > <https://reviews.apache.org/r/50123/diff/12/?file=1507908#file1507908line76>
> >
> >     This will cause build failed on Mac OS as `NvidiaGpuAllocator` was only defined
in linux https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp#L21
> >     
> >     I think that you can follow the same way as we did for `NvidiaComponents` https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp#L27

changed `#include "slave/containerizer/mesos/isolators/gpu/nvidia.hpp"` to `#include "slave/containerizer/mesos/isolators/gpu/components.hpp"`.


- Yubo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review151936
-----------------------------------------------------------


On 十月 11, 2016, 8:16 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50123/
> -----------------------------------------------------------
> 
> (Updated 十月 11, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added 'NvidiaGpuAllocator' to docker containerizer process so that
> docker containerizer process is ready to use it to allocate GPUs to task
> with 'gpus' resource.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d 
>   src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 
>   src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 
>   src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c 
> 
> Diff: https://reviews.apache.org/r/50123/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message