mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.
Date Mon, 10 Oct 2016 17:47:26 GMT


> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote:
> > src/examples/persistent_shared_volume_framework.cpp, line 191
> > <https://reviews.apache.org/r/45963/diff/15/?file=1511368#file1511368line191>
> >
> >     s/used/uses/

It looks like this typo is still present? Or perhaps you meant to drop the issue instead of
resolve?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/#review151731
-----------------------------------------------------------


On Oct. 5, 2016, 12:04 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45963/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4324
>     https://issues.apache.org/jira/browse/MESOS-4324
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow the task to specify the persistent volume access to be read-only
> or read-write. Note that the persistent volume is always created as
> read-write.
> If the task is the first consumer of the shared persistent volume, then
> set the ownership of the persistent volume to match that of the task.
> Otherwise, allow the task to be executed only if the ownership of the
> persistent volume matches that of the task.
> Added an option to run the test in mixed (default) mode or shared-only
> mode. In mixed mode, multiple shards alternate between shared and
> unshared persistent volumes for the tasks. In shared-only mode, all
> shards use shared persistent volumes for the tasks.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/master/validation.hpp 035f721c610ae566c89a1cf0e65ff0df11679f15 
>   src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 0a85935550e36c9142d845465cfa70a1634a647a

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ea418252956c8089acc5a491888ed7f6df6cafcd

>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 794b6e5990db5f8eb21a6535872f284ca02e0553

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp af427c6e5691f1770ab3ebef79502eb2c2176c4a

> 
> Diff: https://reviews.apache.org/r/45963/diff/
> 
> 
> Testing
> -------
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message