mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52208: Fixed warnings in health_checker.cpp.
Date Mon, 10 Oct 2016 17:29:28 GMT


> On Oct. 10, 2016, 8:25 a.m., Alexander Rukletsov wrote:
> > src/health-check/health_checker.cpp, line 179
> > <https://reviews.apache.org/r/52208/diff/1/?file=1509029#file1509029line179>
> >
> >     Why haven't you used `Duration::create()`?

Didn't realize that existed :)

That does look safer than plain-old casting.  I will leave it up to you, if you want to fix
it.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52208/#review151986
-----------------------------------------------------------


On Sept. 22, 2016, 9:50 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52208/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in health_checker.cpp.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp 758cbb382b08743f518022ba66eaafbea7615592 
> 
> Diff: https://reviews.apache.org/r/52208/diff/
> 
> 
> Testing
> -------
> 
> Windows: buils
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message